Skip to content

C++/C#/Java/JavaScript/Python: Remove singleton set literals. #6878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

aschackmull
Copy link
Contributor

Cosmetic style fixes.

@aschackmull aschackmull added the no-change-note-required This PR does not need a change note label Oct 14, 2021
@aschackmull aschackmull requested review from a team as code owners October 14, 2021 09:35
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# 👍

Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ 👍

Copy link
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python OK.

Most of these rewrites looks good to me.

But for something like the inline expectation tests, it actually it is a bit more convenient to have the list of relevant tags be a set literal, so it's easy to expand (or copy paste the boilerplate code).

override string getARelevantTag() { result in ["loggingInput"] }

I would think it's the same for modeling-as-data, where having it as a set literal makes it a bit easier to add new entries

      row =
        ["System.Data.Entity;DbSet;false;SqlQuery;(System.String,System.Object[]);;Argument[0];sql"]

I don't really see a good way to automatically find these, so not going to make too much of a fuss about it.

@aschackmull aschackmull merged commit 8b6baa2 into github:main Oct 14, 2021
@aschackmull aschackmull deleted the remove-singleton-setliteral branch October 14, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants