Skip to content

C#: Add explicit this qualifiers #6880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2021
Merged

C#: Add explicit this qualifiers #6880

merged 2 commits into from
Oct 14, 2021

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Oct 14, 2021

Thanks @erik-krogh for auto-generating the first commit.

@hvitved hvitved requested review from a team as code owners October 14, 2021 09:57
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Oct 14, 2021
erik-krogh
erik-krogh approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS 👍 (only XML.qll was affected).

tausbn
tausbn approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 👍

MathiasVP
MathiasVP approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C++ 👍

aschackmull
aschackmull approved these changes Oct 14, 2021
View reviewed changes
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java 👍

@aschackmull aschackmull merged commit 10d6803 into github:main Oct 14, 2021
@hvitved hvitved deleted the csharp/explicit-this branch October 14, 2021 11:31
@erik-krogh erik-krogh mentioned this pull request Oct 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tausbn tausbn tausbn approved these changes

@MathiasVP MathiasVP MathiasVP approved these changes

@aschackmull aschackmull aschackmull approved these changes

@erik-krogh erik-krogh erik-krogh approved these changes

+1 more reviewer

@tamasvajk tamasvajk tamasvajk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
C# C++ Java JS no-change-note-required This PR does not need a change note Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hvitved @tausbn @MathiasVP @tamasvajk @aschackmull @erik-krogh