Skip to content

C++/Python: Remove unnecessary exists #6882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2021
Merged

C++/Python: Remove unnecessary exists #6882

merged 2 commits into from
Oct 14, 2021

Conversation

MathiasVP
Copy link
Contributor

This PR removes exists(x) when the existence of x is implied by other conjuncts.

@MathiasVP MathiasVP requested review from a team as code owners October 14, 2021 11:08
RasmusWL
RasmusWL approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python LGTM 👍

@aschackmull aschackmull merged commit f6a517c into github:main Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RasmusWL RasmusWL RasmusWL approved these changes

Assignees
No one assigned
Labels
C++ Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MathiasVP @RasmusWL @aschackmull