Skip to content

C#: Handle Nullable<T> default parameter values in assemblies #6890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2021
Merged

C#: Handle Nullable<T> default parameter values in assemblies #6890

merged 1 commit into from
Oct 18, 2021

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Oct 15, 2021

Fixes the extractor messages mentioned on github/codeql-action#772.

Very likely also fixes github/codeql-cli-binaries#86 and #6874.

@hvitved hvitved requested a review from a team as a code owner October 15, 2021 12:27
@github-actions github-actions bot added the C# label Oct 15, 2021
tamasvajk
tamasvajk approved these changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@tamasvajk tamasvajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for finding and fixing this issue.

@hvitved hvitved merged commit 47ae76f into github:main Oct 18, 2021
@hvitved hvitved deleted the csharp/nullable-default-param branch October 18, 2021 06:55
@hvitved hvitved mentioned this pull request Oct 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@tamasvajk tamasvajk tamasvajk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@tamasvajk tamasvajk

Labels
C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Analyze database error with csharp c# bundle suite "Unhandled literal type"
2 participants
@hvitved @tamasvajk