Skip to content

Java: Replace @type with more specific types #6921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 25, 2021

Conversation

igfoo
Copy link
Contributor

@igfoo igfoo commented Oct 20, 2021

No description provided.

@igfoo igfoo added Java no-change-note-required This PR does not need a change note labels Oct 20, 2021
@igfoo igfoo requested a review from a team as a code owner October 20, 2021 09:23
@smowton
Copy link
Contributor

smowton commented Oct 20, 2021

Looks sensible; should we tighten the various uses of RefType or Element to refer to these in QL at the same time?

@igfoo
Copy link
Contributor Author

igfoo commented Oct 20, 2021

I left the QL unchanged to minimise the chances of breaking code, but happy to change that too if that's the consensus.

@igfoo
Copy link
Contributor Author

igfoo commented Oct 20, 2021

I've tightened the QL types I found; I didn't see any Elements that need to be changed, though?

@smowton
Copy link
Contributor

smowton commented Oct 20, 2021

Looks good -- the only Element I remembered was from hasName which is of course mashing a lot of different alternates together anyhow so doesn't need changing

@aschackmull aschackmull merged commit 5709365 into github:main Oct 25, 2021
@igfoo igfoo deleted the igfoo/types branch October 25, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Java no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants