Skip to content

Ruby: Prune nodes before computing trackUseNode #7028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Nov 2, 2021

First perform a forwards sweep (pruneUseNodeFwd) followed by a backwards sweep (pruneUseNodeRev), before computing trackUseNode.

@github-actions github-actions bot added the Ruby label Nov 2, 2021
@hvitved hvitved force-pushed the ruby/api-graphs-prune branch from 8fac47e to 7c23e97 Compare November 3, 2021 10:23
@hvitved hvitved marked this pull request as ready for review November 3, 2021 14:22
@hvitved hvitved requested a review from a team as a code owner November 3, 2021 14:22
aibaars
aibaars previously approved these changes Nov 3, 2021
Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Perhaps the Javascript and/or Python teams should have a look too. Our ApiGraph implementation is based on theirs, so perhaps they can do a similar optimization. @github/codeql-python @github/codeql-javascript

@hvitved
Copy link
Contributor Author

hvitved commented Nov 4, 2021

I would like to rebase this once #7059 is merged, and rerun the performance check.

@hvitved hvitved force-pushed the ruby/api-graphs-prune branch from f8be0a4 to 7178a98 Compare November 9, 2021 14:16
@hvitved
Copy link
Contributor Author

hvitved commented Nov 10, 2021

@aibaars : I have rebased and rerun the performance checks; things are still looking good.

@hvitved hvitved merged commit 004144b into github:main Nov 11, 2021
@hvitved hvitved deleted the ruby/api-graphs-prune branch November 11, 2021 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants