Skip to content

C#: Use cs/ prefix in all query IDs #7041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2021
Merged

C#: Use cs/ prefix in all query IDs #7041

merged 1 commit into from
Nov 8, 2021

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Nov 3, 2021

Similar to #7026.

@hvitved hvitved requested a review from a team as a code owner November 3, 2021 09:26
@github-actions github-actions bot added the C# label Nov 3, 2021
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Nov 3, 2021
tamasvajk
tamasvajk approved these changes Nov 4, 2021
View reviewed changes
Copy link
Contributor

@tamasvajk tamasvajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Is it okay to have two checks with the same cs/print-ast id?

@hvitved
Copy link
Contributor Author

hvitved commented Nov 8, 2021

Is it okay to have two checks with the same cs/print-ast id?

I think so; before they were both calls csharp/print-ast.

@hvitved hvitved merged commit 77aca0a into github:main Nov 8, 2021
@hvitved hvitved deleted the csharp/consistent-ids branch November 8, 2021 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@tamasvajk tamasvajk tamasvajk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@tamasvajk tamasvajk

Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @tamasvajk