Skip to content

Ruby: Fix QL tests and Rust compilation error #7043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 3, 2021

Conversation

aibaars
Copy link
Contributor

@aibaars aibaars commented Nov 3, 2021

For some reason the rust compiler on linux started complaining about the following while accepting the code on windows and osx. I suspect this is due to a newer version of rust on the actions-virtualenvironments .

error[E0282]: type annotations needed
   --> node-types/src/lib.rs:103:9
    |
103 |     let iter = node_types.iter().map(convert_type).collect();
    |         ^^^^ consider giving `iter` a type

For more information about this error, try `rustc --explain E0282`.

See also: https://github.com/github/codeql/actions/runs/1412583767

In addition this pull request fixes the dbscheme upgrades tests that started failing. I wonder why they ever worked because the path supplied to --additional-packs is not a root folder of a pack (it's a subfolder). I suppose the codeql CLI has gotten more strict. Failed job here: https://github.com/aibaars/codeql/runs/4079041121?check_suite_focus=true

Finally this pull request adds the workflow paths to the paths section of push and pull_request triggers to ensure they are run whenever we change the workflows.

@aibaars aibaars added Ruby no-change-note-required This PR does not need a change note labels Nov 3, 2021
@aibaars aibaars marked this pull request as ready for review November 3, 2021 11:50
@aibaars aibaars requested a review from a team as a code owner November 3, 2021 11:50
@aibaars aibaars changed the title Fix ql tests 3.3 Fix QL tests and Ruby compilation error Nov 3, 2021
@aibaars aibaars changed the title Fix QL tests and Ruby compilation error Ruby: Fix QL tests and Rust compilation error Nov 3, 2021
Copy link
Contributor

@nickrolfe nickrolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I can reproduce the Rust error on mac OS with the latest rustc (1.56.1). Note that the same fix was already made on main when we fixed all the problems reported by cargo clippy. I hope it'll merge back cleanly, since they are identical changes.

@aibaars aibaars merged commit 1327d7c into github:rc/3.3 Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants