Skip to content

Conversation

redsun82
Copy link
Contributor

After updating the frontend new intermediate objects appear in the AST and raw dumps.

@redsun82 redsun82 added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Nov 11, 2021
@redsun82 redsun82 requested a review from a team as a code owner November 11, 2021 14:01
@github-actions github-actions bot added the C++ label Nov 11, 2021
MathiasVP
MathiasVP previously approved these changes Nov 11, 2021
@MathiasVP MathiasVP dismissed their stale review November 11, 2021 15:28

Oops! Still a couple of failing tests that need to be accepted.

@redsun82 redsun82 force-pushed the redsun82/frontend-update branch 2 times, most recently from 9a6d862 to b20f6c2 Compare November 15, 2021 16:14
@redsun82 redsun82 requested a review from MathiasVP November 16, 2021 10:33
MathiasVP
MathiasVP previously approved these changes Nov 16, 2021
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

After updating the frontend new intermediate objects appear in the AST
and raw dumps.
@redsun82 redsun82 merged commit 2ce5b85 into main Nov 16, 2021
@redsun82 redsun82 deleted the redsun82/frontend-update branch November 16, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants