Skip to content

Ruby: Fix performance problem in Definitions.ql #7123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2021
Merged

Ruby: Fix performance problem in Definitions.ql #7123

merged 2 commits into from
Nov 15, 2021

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Nov 12, 2021

Avoids computing this large set:

[2021-11-12 14:31:11] (542s) Tuple counts for Definitions::definitionOf#ff#min_term/5@cc3ffc after 2m10s:
                      337397265 ~3%     {5} r1 = JOIN Definitions::definitionOf#ff#shared WITH Module::Cached::resolveConstant#ff_10#join_rhs ON FIRST 1 OUTPUT Rhs.1 'arg0', Lhs.2 'arg3', Lhs.1 'arg4', Lhs.2 'arg3', Lhs.1 'arg4'
                                        return r1

@hvitved hvitved requested a review from a team as a code owner November 12, 2021 13:36
@github-actions github-actions bot added the Ruby label Nov 12, 2021
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Nov 12, 2021
aibaars
aibaars reviewed Nov 12, 2021
View reviewed changes
aibaars
aibaars previously approved these changes Nov 12, 2021
View reviewed changes
Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just one question.

@hvitved hvitved merged commit d323b3b into github:main Nov 15, 2021
@hvitved hvitved deleted the ruby/definitions-perf branch November 15, 2021 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aibaars aibaars aibaars approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @aibaars