Skip to content

Conversation

xiemaisi
Copy link

@xiemaisi xiemaisi commented Jan 1, 2019

No description provided.

@xiemaisi xiemaisi added the JS label Jan 1, 2019
@xiemaisi xiemaisi requested a review from a team as a code owner January 1, 2019 08:48
@xiemaisi xiemaisi added the WIP This is a work-in-progress, do not merge yet! label Jan 1, 2019
@xiemaisi
Copy link
Author

xiemaisi commented Jan 1, 2019

Probably best to delay this until after the branching has been sorted out, so marking as WIP.

asger-semmle
asger-semmle previously approved these changes Jan 2, 2019
Copy link
Contributor

@asger-semmle asger-semmle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@xiemaisi xiemaisi removed the WIP This is a work-in-progress, do not merge yet! label Jan 7, 2019
@xiemaisi
Copy link
Author

xiemaisi commented Jan 7, 2019

Rebased. With the branching structure now sorted out, I'd be keen on getting this in soon to avoid more pain later on.

@ghost
Copy link

ghost commented Jan 7, 2019

The Language-Tests/JavaScript test failures seem unrelated to the refactoring..

@xiemaisi
Copy link
Author

xiemaisi commented Jan 7, 2019

Indeed; I'm told the problem that caused the failure is now fixed, so I've retriggered.

@semmle-qlci semmle-qlci merged commit 8b8b352 into github:master Jan 7, 2019
@xiemaisi xiemaisi deleted the js/autoformat branch January 8, 2019 09:43
cklin pushed a commit that referenced this pull request Apr 26, 2022
…e-space

Pretty-print empty interface without double space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants