Java: Don't clear content in store steps in summaries. #7187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschackmull
added
the
no-change-note-required
atorralba
reviewed
Nov 19, 2021
| @@ -150,8 +150,7 @@ predicate readStep(Node node1, Content f, Node node2) { | |||
| * in `x.f = newValue`. | |||
| */ | |||
| predicate clearsContent(Node n, Content c) { | |||
| c instanceof FieldContent and | |||
| n = any(PostUpdateNode pun | storeStep(_, c, pun)).getPreUpdateNode() | |||
| exists(FieldAccess fa | instanceFieldAssign(_, fa) and n = getFieldQualifier(fa)) | |||
There was a problem hiding this comment.
OOC: Isn't a problem that c is now unbound here?
There was a problem hiding this comment.
Good catch. That's a bug.
hvitved
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store steps in summaries aren't likely to be intended to clear the targeted content (also, this currently doesn't even work consistently). This caused false negative flow for any field-of-argument-to-callback summary as these summaries simply didn't work.
This fix could alternatively have been achieved by changing the synthesised read-/store-steps such that more store steps would be inferred as side-effects through reverse reads, but that seemed unnecessarily complicated.