-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Data flow: Performance tuning #7232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if DCA is happy! I'm curious about the performance implications of removing disjunction-induced tuple duplication. (Could we have a ql-for-ql query for this?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 from Python (after also talking through what some of the changes do 👍)
This is a sequence of smaller performance tweaks (commit-by-commit review is encouraged). All of them relate to reducing work by avoiding splits of the tuple stream in the main recursive pipelines. Either by making sure negations are simple anti-joins (thereby also avoiding materialisation) or by avoiding tuple duplication arising from disjunctive filters.