Data flow: Introduce ConsistencyConfiguration class
#7237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
dataflow/consistency-config
branch
from
a1406c6 to
6cb0099
Compare
MathiasVP
reviewed
Nov 25, 2021
cpp/ql/lib/semmle/code/cpp/dataflow/internal/DataFlowImplConsistency.qll
Show resolved
Hide resolved
aschackmull
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for more fine-grained per-language configuration of the consistency queries. Currently, only two consistency queries can be controlled, but we can easily add support for others.
Ruby appears to be the only language that uses a "real" consistency query, so there I could move the configuration into the query itself. For the other languages I simply added it to
DataFlowPrivate.qll; but consider moving it when/if switching over to--consistency-queriesbased approach.