C#: Convert flow summaries to CSV format. #7304

michaelnebel · 2021-12-03T13:53:33Z

The following is covered by this PR

System.String
System.Text.StringBuilder
System.Lazy
System.Nullable
System.Convert

github-actions · 2021-12-03T13:55:51Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",3,13,28,5
+    System,"``System.*``, ``System``",3,549,28,5
-    Totals,,3,20,353,5
+    Totals,,3,556,353,5

Changes to framework-coverage-csharp.csv:

- package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint
+ package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint,summary:value
- Dapper,55,,,,,,55,,,
+ Dapper,55,,,,,,55,,,,
- Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,
- MySql.Data.MySqlClient,48,,,,,,48,,,
+ MySql.Data.MySqlClient,48,,,,,,48,,,,
- ServiceStack,194,,7,27,,75,92,,,7
+ ServiceStack,194,,7,27,,75,92,,,7,
- System,28,3,13,,4,,23,1,3,13
+ System,28,3,549,,4,,23,1,3,456,93

github-actions · 2021-12-03T14:10:50Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",3,13,28,5
+    System,"``System.*``, ``System``",3,549,28,5
-    Totals,,3,20,353,5
+    Totals,,3,556,353,5

Changes to framework-coverage-csharp.csv:

- package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint
+ package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint,summary:value
- Dapper,55,,,,,,55,,,
+ Dapper,55,,,,,,55,,,,
- Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,
- MySql.Data.MySqlClient,48,,,,,,48,,,
+ MySql.Data.MySqlClient,48,,,,,,48,,,,
- ServiceStack,194,,7,27,,75,92,,,7
+ ServiceStack,194,,7,27,,75,92,,,7,
- System,28,3,13,,4,,23,1,3,13
+ System,28,3,549,,4,,23,1,3,456,93

github-actions · 2021-12-03T14:13:02Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",3,25,28,5
+    System,"``System.*``, ``System``",3,561,28,5
-    Totals,,3,32,353,5
+    Totals,,3,568,353,5

Changes to framework-coverage-csharp.csv:

- package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint
+ package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint,summary:value
- Dapper,55,,,,,,55,,,
+ Dapper,55,,,,,,55,,,,
- Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,
- MySql.Data.MySqlClient,48,,,,,,48,,,
+ MySql.Data.MySqlClient,48,,,,,,48,,,,
- ServiceStack,194,,7,27,,75,92,,,7
+ ServiceStack,194,,7,27,,75,92,,,7,
- System,28,3,25,,4,,23,1,3,25
+ System,28,3,561,,4,,23,1,3,468,93

github-actions · 2021-12-06T08:48:16Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",3,25,28,5
+    System,"``System.*``, ``System``",3,561,28,5
-    Totals,,3,32,353,5
+    Totals,,3,568,353,5

Changes to framework-coverage-csharp.csv:

- package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint
+ package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint,summary:value
- Dapper,55,,,,,,55,,,
+ Dapper,55,,,,,,55,,,,
- Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,
- MySql.Data.MySqlClient,48,,,,,,48,,,
+ MySql.Data.MySqlClient,48,,,,,,48,,,,
- ServiceStack,194,,7,27,,75,92,,,7
+ ServiceStack,194,,7,27,,75,92,,,7,
- System,28,3,25,,4,,23,1,3,25
+ System,28,3,561,,4,,23,1,3,468,93

github-actions · 2021-12-09T09:08:52Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",3,25,28,5
+    System,"``System.*``, ``System``",3,561,28,5
-    Totals,,3,32,353,5
+    Totals,,3,568,353,5

Changes to framework-coverage-csharp.csv:

- package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint
+ package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint,summary:value
- Dapper,55,,,,,,55,,,
+ Dapper,55,,,,,,55,,,,
- Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,
- MySql.Data.MySqlClient,48,,,,,,48,,,
+ MySql.Data.MySqlClient,48,,,,,,48,,,,
- ServiceStack,194,,7,27,,75,92,,,7
+ ServiceStack,194,,7,27,,75,92,,,7,
- System,28,3,25,,4,,23,1,3,25
+ System,28,3,561,,4,,23,1,3,468,93

github-actions · 2021-12-09T15:40:19Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",3,25,28,5
+    System,"``System.*``, ``System``",3,561,28,5
-    Totals,,3,32,353,5
+    Totals,,3,568,353,5

Changes to framework-coverage-csharp.csv:

- package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint
+ package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint,summary:value
- Dapper,55,,,,,,55,,,
+ Dapper,55,,,,,,55,,,,
- Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,
- MySql.Data.MySqlClient,48,,,,,,48,,,
+ MySql.Data.MySqlClient,48,,,,,,48,,,,
- ServiceStack,194,,7,27,,75,92,,,7
+ ServiceStack,194,,7,27,,75,92,,,7,
- System,28,3,25,,4,,23,1,3,25
+ System,28,3,561,,4,,23,1,3,468,93

hvitved

LGTM, just one comment.

csharp/ql/lib/semmle/code/csharp/frameworks/system/Text.qll

github-actions · 2021-12-10T09:30:58Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

Changes to framework-coverage-csharp.rst:

-    System,"``System.*``, ``System``",3,25,28,5
+    System,"``System.*``, ``System``",3,561,28,5
-    Totals,,3,32,353,5
+    Totals,,3,568,353,5

Changes to framework-coverage-csharp.csv:

- package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint
+ package,sink,source,summary,sink:code,sink:html,sink:remote,sink:sql,sink:xss,source:local,summary:taint,summary:value
- Dapper,55,,,,,,55,,,
+ Dapper,55,,,,,,55,,,,
- Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,
+ Microsoft.ApplicationBlocks.Data,28,,,,,,28,,,,
- MySql.Data.MySqlClient,48,,,,,,48,,,
+ MySql.Data.MySqlClient,48,,,,,,48,,,,
- ServiceStack,194,,7,27,,75,92,,,7
+ ServiceStack,194,,7,27,,75,92,,,7,
- System,28,3,25,,4,,23,1,3,25
+ System,28,3,561,,4,,23,1,3,468,93

hvitved

LGTM. But let's not merge before we see the result of the DCA run.

github-actions bot added the C# label Dec 3, 2021

michaelnebel force-pushed the csharp-mad-as-csv2 branch 2 times, most recently from 24fc834 to a69ac0b Compare December 3, 2021 14:10

michaelnebel force-pushed the csharp-mad-as-csv2 branch from a69ac0b to 7edc6be Compare December 6, 2021 08:46

michaelnebel force-pushed the csharp-mad-as-csv2 branch from 7edc6be to f6a0ea8 Compare December 9, 2021 09:06

michaelnebel added 7 commits December 9, 2021 16:34

C#: Convert System.String flow to CSV format.

5376eb8

C#: Allow the use of pointer types in CSV validation.

5a26346

C#: Convert System.Text.StringBuilder flow to CSV format.

9e61dfb

C#: Convert System.Lazy<> flow to CSV format.

bbab0e5

C#: Convert System.Nullable<> flow to CSV format.

15b4b21

C#: Convert System.Convert flow to CSV format.

e879ca7

C#: Manual update of System.String and System.Convert flow summaries.

d60b90a

michaelnebel force-pushed the csharp-mad-as-csv2 branch from f6a0ea8 to d60b90a Compare December 9, 2021 15:37

michaelnebel marked this pull request as ready for review December 10, 2021 07:27

michaelnebel requested a review from a team as a code owner December 10, 2021 07:27

hvitved requested changes Dec 10, 2021

View reviewed changes

csharp/ql/lib/semmle/code/csharp/frameworks/system/Text.qll Show resolved Hide resolved

C#: Ensure bi-directional importing of external flow for System.Text.

afa58f5

michaelnebel requested a review from hvitved December 10, 2021 09:34

hvitved approved these changes Dec 10, 2021

View reviewed changes

michaelnebel merged commit a636021 into github:main Dec 13, 2021

michaelnebel deleted the csharp-mad-as-csv2 branch December 13, 2021 07:56

C#: Convert flow summaries to CSV format. #7304

C#: Convert flow summaries to CSV format. #7304

Uh oh!

Conversation

michaelnebel commented Dec 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 3, 2021

csharp

Generated file changes for csharp

Uh oh!

github-actions bot commented Dec 3, 2021

csharp

Generated file changes for csharp

Uh oh!

github-actions bot commented Dec 3, 2021

csharp

Generated file changes for csharp

Uh oh!

github-actions bot commented Dec 6, 2021

csharp

Generated file changes for csharp

Uh oh!

github-actions bot commented Dec 9, 2021

csharp

Generated file changes for csharp

Uh oh!

github-actions bot commented Dec 9, 2021

csharp

Generated file changes for csharp

Uh oh!

hvitved left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Dec 10, 2021

csharp

Generated file changes for csharp

Uh oh!

hvitved left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

michaelnebel commented Dec 3, 2021 •

edited

Loading