C#: Avoid CIL instructions with multiple types #7321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
reviewed
Dec 9, 2021
Comment on lines
+78
to
+79
| result.(PrimitiveType).getUnderlyingType().getConversionIndex() > | ||
| t2.(PrimitiveType).getUnderlyingType().getConversionIndex() |
There was a problem hiding this comment.
Does this basically check if there's an implicit numeric conversion from t2 to t1? If so, don't we need to also cover other implicit conversions?
There was a problem hiding this comment.
Yes, this only covers implicit conversions. There is also a case for when one of the operands is null. I haven't run into other cases.
| @@ -73,8 +73,8 @@ class ComparisonOperation extends BinaryExpr, @cil_comparison_operation { | |||
| class BinaryArithmeticExpr extends BinaryExpr, @cil_binary_arithmetic_operation { | |||
| override Type getType() { | |||
| exists(Type t0, Type t1 | | |||
| t0 = this.getOperand(0).getType().getUnderlyingType() and | |||
There was a problem hiding this comment.
Maybe adding a comment onto Expr::getType() mentioning that there's an alternative getOperandType which should be used instead of getOperand(X).getType() would be beneficial.
Should all instances be changed?
I found that ex.getExpr().getType() also calls getOperand(X).getType in
tamasvajk
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identified via #7231.