Skip to content

JS: extend syntax of handlebars tags #7327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Dec 17, 2021

Conversation

asgerf
Copy link
Contributor

@asgerf asgerf commented Dec 7, 2021

Recognizes the raw interpolation tag {{& foo }}, and whitespace-trimming tags like {{~ foo }}.

@asgerf asgerf added JS Awaiting evaluation Do not merge yet, this PR is waiting for an evaluation to finish labels Dec 7, 2021
@asgerf asgerf requested a review from a team as a code owner December 7, 2021 12:13
erik-krogh
erik-krogh previously approved these changes Dec 8, 2021
Copy link
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
(Assuming the evaluation works out).

@asgerf asgerf force-pushed the js/handlebars-more-raw-interpolation branch from 5295ae7 to 2b4c7cf Compare December 9, 2021 12:54
@asgerf
Copy link
Contributor Author

asgerf commented Dec 17, 2021

Evaluation looks fine.

@asgerf asgerf force-pushed the js/handlebars-more-raw-interpolation branch from 2b4c7cf to 8977542 Compare December 17, 2021 09:32
@asgerf
Copy link
Contributor Author

asgerf commented Dec 17, 2021

Rebased to resolve conflict in Main.java

@asgerf asgerf removed the Awaiting evaluation Do not merge yet, this PR is waiting for an evaluation to finish label Dec 17, 2021
@codeql-ci codeql-ci merged commit de4b655 into github:main Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants