JS: Improve handling of heuristic sinks in endpoint filters #7351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously heuristic sinks were always included, to avoid us filtering them out due to not being an argument to an external library call. In this commit we move the argument to an external library call filtering to the query-specific endpoint filters. This lets us filter out heuristic sinks if they match one of the other endpoint filters, reducing FPs.
Z80coder
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
I understand the intent of this refactoring, which is to apply per-query endpoint filters to heuristic sinks, and therefore reduce FPs. On the end-to-end metrics the improvement is 1 less FP. In the wild, this may be more. I can't comment on the precise details of the QL refactoring but otherwise LGTM.
henrymercer
deleted the
henrymercer/js-atm-heuristic-sinks-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously heuristic sinks were always included, to avoid us filtering them out due to not being an argument to an external library call. In this PR, we move the "argument to an external library call" filtering to the query-specific endpoint filters. This lets us filter out heuristic sinks if they match one of the other endpoint filters, reducing FPs.