Ruby: Deprecate Pattern classes
#7390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
ruby/deprecate-pattern-classes
branch
from
b202691 to
e882cda
Compare
|
A couple of trivial questions, but otherwise this looks very sensible. |
I don't see any questions? |
nickrolfe
reviewed
Dec 15, 2021
Sorry, you should see them now. I was reviewing from VS Code, but the extension seems very flaky when it comes to submitting reviews. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The various
Patternclasses got introduced before we supported pattern matching, as a common way of describing destructured assignments and destructured parameters. Now, however, they give more rise to confusion (they have nothing to do with pattern matching) than benefit, so I think we should simply deprecate them.I also fixed a bug in the computation of callables belonging to nested destructured parameters.