Fix change notes #7398
Merged
Fix change notes #7398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 14, 2021 12:05
Now that change notes are per-package, new change notes should be created in the `change-notes` folder under the affected pack (e.g., `cpp/ql/src/change-notes` for C++ query change notes. I've moved all of the change note files that were added before we started publishing them in packs to an `old-change-notes` directory under each language, to reduce the temptation to add new change notes there. I'm working on a document to describe how and when to create change notes for packs separately.
aeisenberg
approved these changes
Dec 14, 2021
|
Are there any prepare release workflow changes that need to happen as well? |
Nope. This just moves everything so that the existing release prep workflow will work, and so that people won't keep adding new change notes in the wrong place. I did the same thing for the previous release, except for the renaming the old directory part. |
|
See #7400 for the new instructions on creating change notes. |
|
Looks like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has two separate commits.
change-notesdirectory at the language level (e.g.,cpp/change-notes) toold-change-notesto reduce the temptation to add new change notes there. I'm working separately on a document to describe how to add change notes for a pack.