-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Java: Start running telemetry queries on Code Scanning #7417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Start running telemetry queries on Code Scanning #7417
Conversation
Use the support for summary metrics with messages that'll be in the next version of the CodeQL CLI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not caused by this PR, but it seems worth fixing what looks like a copy/paste error to avoid the following confusion (taken from the example in the PR description).
| Supported sinks in external libraries | (574 results) |
| Supported sinks in external libraries | (22 results) |
Thanks for fixing up the tags (I had a draft PR but never merged it, sorry) @henrymercer - a more general question: Do we run all |
Co-authored-by: yo-h <55373593+yo-h@users.noreply.github.com>
The queries that we'll run on Code Scanning are defined within https://github.com/github/codeql/tree/main/java/ql/src/codeql-suites. I can't find |
@github/codeql-java Would this PR require a changenote? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this PR require a changenote?
We are still evaluating the output of these queries, so I would merge without a change note for now. Unless @turbo knows of a reason to advertise more widely at this time?
This PR incorporates the telemetry queries for Java into the summary metrics framework. Specifically we use the support for summary metrics with messages that was introduced in CodeQL CLI v2.8.0.
This has a few effects:
Example metrics summary table additions
/cc @bmuskalla @turbo @yo-h