-
Notifications
You must be signed in to change notification settings - Fork 1.8k
C#: Introduce extractor mode to identify DBs created with codeql test run
#7515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks nice! I have added some questions/comments and suggestions.
csharp/extractor/Semmle.Extraction.CIL.Driver/ExtractorOptions.cs
Outdated
Show resolved
Hide resolved
csharp/extractor/Semmle.Extraction/Extractor/StandaloneExtractor.cs
Outdated
Show resolved
Hide resolved
csharp/extractor/Semmle.Extraction/Extractor/StandaloneExtractor.cs
Outdated
Show resolved
Hide resolved
csharp/extractor/Semmle.Extraction/Extractor/TracingExtractor.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really nice!
174676f
to
4f90b45
Compare
Rebased to resolve merge conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Passing
--qltest
to the extractor when run thoughcodeql test run
is not done yet, that will be done on an internal follow-up PR.