Skip to content

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Jan 5, 2022

Passing --qltest to the extractor when run though codeql test run is not done yet, that will be done on an internal follow-up PR.

@hvitved hvitved requested a review from a team as a code owner January 5, 2022 11:01
@github-actions github-actions bot added the C# label Jan 5, 2022
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! I have added some questions/comments and suggestions.

michaelnebel
michaelnebel previously approved these changes Jan 19, 2022
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really nice!

@hvitved
Copy link
Contributor Author

hvitved commented Jan 19, 2022

Rebased to resolve merge conflict.

Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hvitved hvitved merged commit 7e3f3c6 into github:main Jan 19, 2022
@hvitved hvitved deleted the csharp/extraction-mode branch January 19, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants