Dataflow: Don't include arg -> param edges in PathGraph::edges where arg is not reachable #7526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
reviewed
Jan 6, 2022
|
The changes to the |
|
Looks like the qltest failures are highlighting a pre-existing bug that I was actually just investigating in a separate context. I don't have a complete overview yet, but I expect to fix it in a separate PR. |
Actually, the fix is simple and would likely conflict, so I'll just push it here. |
…ot reachable This avoids lots of missing-node warnings from `codeql bqrs interpret` as it discards the nodes that occur in the `edges` relation but not `nodes`. The problem arises because subpaths introduced two variants of `reach`, one of which is more restrictive than simply `reach(succ) and succ = pred.getASuccessor()`, so it no longer suffices to just check that the successor is reachable.
aschackmull
force-pushed
the
smowton/fix/restore-nodes-edges-consistency
branch
from
c4e0493 to
9479301
Compare
aschackmull
approved these changes
Jan 18, 2022
hvitved
approved these changes
Jan 18, 2022
owen-mc
changed the title
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 9, 2022
In the `subpaths` section, the last node is now printed without its type if it is the sink of the path. This comes from the commit "Dataflow: Bugfix: include subpaths ending at a sink. " in github#7526
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 9, 2022
In the `subpaths` section, the last node is now printed without its type if it is the sink of the path. This comes from the commit "Dataflow: Bugfix: include subpaths ending at a sink. " in github#7526
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 9, 2022
In the `subpaths` section, the last node is now printed without its type if it is the sink of the path. This comes from the commit "Dataflow: Bugfix: include subpaths ending at a sink. " in github#7526
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 17, 2022
In the `subpaths` section, the last node is now printed without its type if it is the sink of the path. This comes from the commit "Dataflow: Bugfix: include subpaths ending at a sink. " in github#7526
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids lots of missing-node warnings from
codeql bqrs interpretas it discards the nodes that occur in theedgesrelation but notnodes. The problem arises because subpaths introduced two variants ofreach, one of which is more restrictive than simplyreach(succ) and succ = pred.getASuccessor(), so it no longer suffices to just check that the successor is reachable.Suggestions re: the best way to test this welcome.