Skip to content

JS: Update names, IDs, and tags for ML-powered queries #7594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2022
Merged

JS: Update names, IDs, and tags for ML-powered queries #7594

merged 1 commit into from
Jan 14, 2022

Conversation

henrymercer
Copy link
Contributor

  • Change the (boosted) suffix in the query name to (experimental) (we can rename this later without causing alerts to be closed/opened)
  • Remove the experimental/atm tag — this was requested to improve how the alerts look in the UI
  • Update the query IDs to js/ml-powered/*

@henrymercer henrymercer requested a review from Z80coder January 13, 2022 17:47
@henrymercer henrymercer requested a review from a team as a code owner January 13, 2022 17:47
@github-actions github-actions bot added the JS label Jan 13, 2022
Z80coder
Z80coder approved these changes Jan 14, 2022
View reviewed changes
Copy link
Contributor

@Z80coder Z80coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@henrymercer henrymercer merged commit d55e6d1 into main Jan 14, 2022
@henrymercer henrymercer deleted the henrymercer/js-atm-rename-queries branch January 14, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@Z80coder Z80coder Z80coder approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henrymercer @Z80coder