-
Notifications
You must be signed in to change notification settings - Fork 1.8k
C#: Desugar property patterns that uses member access syntax. #7720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#: Desugar property patterns that uses member access syntax. #7720
Conversation
8c1b2ac
to
c353515
Compare
c353515
to
abe6d08
Compare
…y are de-sugared correctly).
abe6d08
to
f1d5d3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It would be nice to have data flow tests for this as well, e.g. in ql/test/library-tests/dataflow/fields/
.
csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/Patterns/PropertyPattern.cs
Outdated
Show resolved
Hide resolved
csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/Patterns/PropertyPattern.cs
Outdated
Show resolved
Hide resolved
csharp/extractor/Semmle.Extraction.CSharp/Entities/Expressions/Patterns/PropertyPattern.cs
Outdated
Show resolved
Hide resolved
Yes, that is a good idea, but I don't think that pattern matching is really supported in the dataflow library. public struct Struct
{
public object Field;
public object Prop { get; init; }
public Struct(object field, object prop) => (Field, Prop) = (field, prop);
}
private void M1()
{
var o = Source<object>(1);
var s = new Struct(o, o);
if (s is Struct { Field: object p })
{
Sink(p); // $ hasValueFlow=1
}
} An issue has been created for this. |
In this PR we make support for Extended property patterns.
The idea is that the new form is de-sugared into a pattern expression in the old form. The only difference will be some slightly different locations.