-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add new groups for examples packs #7724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
255ea8f
to
bf1f43f
Compare
@aeisenberg Don't forget to resolve the conflicting files and use arrays for the groups property in those too. |
Also, remove version numbers. Will make it easier to avoid publishing the examples packs.
bf1f43f
to
a7f755c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from C# perspective.
@@ -1,4 +1,6 @@ | |||
name: codeql/csharp-examples | |||
version: 0.0.2 | |||
groups: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why has the version number been removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not making any particular versioning guarantees for the example packs. They're just sample code that sits in a Git repo for customers to look at, rather than an officially supported pack that gets published to the package registry and consumed by real Code Scanning runs.
@@ -1,4 +1,6 @@ | |||
name: codeql/csharp-examples | |||
version: 0.0.2 | |||
groups: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not making any particular versioning guarantees for the example packs. They're just sample code that sits in a Git repo for customers to look at, rather than an officially supported pack that gets published to the package registry and consumed by real Code Scanning runs.
Will make it easier to avoid publishing them.