Skip to content

Add new groups for examples packs #7724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Add new groups for examples packs #7724

merged 1 commit into from
Jan 27, 2022

Conversation

aeisenberg
Copy link
Contributor

Will make it easier to avoid publishing them.

michaelnebel
michaelnebel previously approved these changes Jan 25, 2022
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

hvitved
hvitved previously approved these changes Jan 25, 2022
@aeisenberg aeisenberg dismissed stale reviews from hvitved and michaelnebel via 255ea8f January 26, 2022 20:46
@aeisenberg aeisenberg force-pushed the aeisenberg/examples-groups branch 2 times, most recently from 255ea8f to bf1f43f Compare January 26, 2022 20:48
@aibaars
Copy link
Contributor

aibaars commented Jan 26, 2022

@aeisenberg Don't forget to resolve the conflicting files and use arrays for the groups property in those too.

Also, remove version numbers. Will make it easier to avoid publishing
the examples packs.
@aeisenberg aeisenberg force-pushed the aeisenberg/examples-groups branch from bf1f43f to a7f755c Compare January 26, 2022 22:49
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from C# perspective.

@@ -1,4 +1,6 @@
name: codeql/csharp-examples
version: 0.0.2
groups:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has the version number been removed?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not making any particular versioning guarantees for the example packs. They're just sample code that sits in a Git repo for customers to look at, rather than an officially supported pack that gets published to the package registry and consumed by real Code Scanning runs.

@@ -1,4 +1,6 @@
name: codeql/csharp-examples
version: 0.0.2
groups:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not making any particular versioning guarantees for the example packs. They're just sample code that sits in a Git repo for customers to look at, rather than an officially supported pack that gets published to the package registry and consumed by real Code Scanning runs.

@dbartol dbartol merged commit cca74e9 into main Jan 27, 2022
@dbartol dbartol deleted the aeisenberg/examples-groups branch January 27, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants