Skip to content

C#: Remove some unused legacy relations from the DB scheme #7746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 26, 2022
Merged

C#: Remove some unused legacy relations from the DB scheme #7746

merged 3 commits into from
Jan 26, 2022

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Jan 26, 2022 •
edited
Loading

Remove the following legacy relations:

  • externalDefects
  • externalMetrics
  • externalData
  • snapshotDate
  • duplicateCode
  • similarCode
  • tokens.rel

@github-actions github-actions bot added the C# label Jan 26, 2022
@hvitved hvitved marked this pull request as ready for review January 26, 2022 08:48
@hvitved hvitved requested a review from a team as a code owner January 26, 2022 08:48
@michaelnebel michaelnebel self-requested a review January 26, 2022 08:52
@michaelnebel
Copy link
Contributor

Looks good to me! Did you manually change the stats file and should we consider run (1) DCA stat generation (2) DCA performance test

michaelnebel
michaelnebel approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent to eliminate dead stuff!

@hvitved
Copy link
Contributor Author

hvitved commented Jan 26, 2022

Did you manually change the stats file and should we consider run (1) DCA stat generation (2) DCA performance test

I manually deleted the entries for the deleted relations. A DCA performance test should not be needed, as these stats only pertained to relations that are not used in any queries.

@hvitved hvitved merged commit 477f83c into github:main Jan 26, 2022
@hvitved hvitved deleted the csharp/remove-legacy-relations branch January 26, 2022 09:40
@hvitved hvitved mentioned this pull request Jan 26, 2022
Merged
@jketema jketema mentioned this pull request Feb 11, 2022
Merged
@nickrolfe nickrolfe mentioned this pull request Feb 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelnebel michaelnebel michaelnebel approved these changes

Assignees
No one assigned
Labels
C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @michaelnebel