Skip to content

C#: Use .NET 6 #7784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 3, 2022
Merged

C#: Use .NET 6 #7784

merged 6 commits into from
Feb 3, 2022

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Jan 28, 2022

No description provided.

@hvitved hvitved changed the title Csharp/dotnet6 C#: Use .NET 6 Jan 28, 2022
@hvitved hvitved added depends on internal PR This PR should only be merged in sync with an internal Semmle PR and removed documentation labels Jan 28, 2022
@hvitved hvitved force-pushed the csharp/dotnet6 branch 7 times, most recently from 3e5f106 to debf01b Compare February 1, 2022 13:12
@hvitved hvitved marked this pull request as ready for review February 3, 2022 08:13
@hvitved hvitved requested review from a team as code owners February 3, 2022 08:13
tamasvajk
tamasvajk approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@tamasvajk tamasvajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks plausible

csharp/extractor/Semmle.Extraction.CSharp/Entities/UserOperator.cs
Comment on lines +181 to +182
if (method.ExplicitInterfaceImplementations.Any())
return OperatorSymbol(cx, method.ExplicitInterfaceImplementations.First());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been an issue all along, but with the upgrade we ran into it in the tests, which we didn't before.

michaelnebel
michaelnebel approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me!
I suppose the failing test are caused by a needed update in the semmle-code repo, which will be made in another PR?

@hvitved
Copy link
Contributor Author

hvitved commented Feb 3, 2022

I suppose the failing test are caused by a needed update in the semmle-code repo, which will be made in another PR?

Yes.

@hvitved hvitved merged commit ef227a4 into github:main Feb 3, 2022
@hvitved hvitved deleted the csharp/dotnet6 branch February 3, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelnebel michaelnebel michaelnebel approved these changes

+1 more reviewer

@tamasvajk tamasvajk tamasvajk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
C# C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hvitved @michaelnebel @tamasvajk