Skip to content

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Jan 31, 2022

Computing a full transitive closure is often bad; by inlining all calls we are providing more context to the QL optimizer.

Computing a full transitive closure is often bad; by inlining all calls we are
providing more context to the QL optimizer.
@hvitved hvitved marked this pull request as ready for review February 2, 2022 09:35
@hvitved hvitved requested review from a team as code owners February 2, 2022 09:35
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible to me!

Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hvitved hvitved merged commit 6bb71f0 into github:main Feb 3, 2022
@hvitved hvitved deleted the dataflow/inline-local-flow-star branch February 3, 2022 08:02
owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 9, 2022
owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 9, 2022
owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 9, 2022
owen-mc added a commit to owen-mc/codeql that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants