JS: Adding model for .get function of Map in Unvalidated Dynamic Method Call
#7828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naman-ntc
commented
Feb 3, 2022
javascript/ql/test/query-tests/Security/CWE-754/UnvalidatedDynamicMethodCallGood4.js
Outdated
Show resolved
Hide resolved
Naman-ntc
commented
Feb 3, 2022
| app.get('/perform/:action/:payload', function(req, res) { | ||
| let action = actions.get(req.params.action); | ||
| // GOOD: `action` is either the `play` or the `pause` function from above | ||
| if (typeof action === 'function') { |
There was a problem hiding this comment.
This should not be flagged because action cannot be from proto right?
There was a problem hiding this comment.
That sounds right, a call to get on a map shouldn't be able to return something from the prototype.
I've seen a bunch of get implementations that are implemented like function get(x) {return obj[x];}, but if that's the case, then the query should pick up on the dynamic property read inside the get function.
Naman-ntc
changed the title
.get function of Map.get function of Map in Unvalidated Dynamic Method Call
owen-mc
changed the title
.get function of Map in Unvalidated Dynamic Method Call.get function of Map in Unvalidated Dynamic Method Call
erik-krogh
reviewed
Feb 4, 2022
javascript/ql/test/query-tests/Security/CWE-754/UnvalidatedDynamicMethodCallGood4.js
Outdated
Show resolved
Hide resolved
javascript/ql/test/query-tests/Security/CWE-754/UnvalidatedDynamicMethodCallGood3.js
Outdated
Show resolved
Hide resolved
…amicMethodCallGood4.js Co-authored-by: Erik Krogh Kristensen <erik-krogh@github.com>
…amicMethodCallGood3.js Co-authored-by: Erik Krogh Kristensen <erik-krogh@github.com>
|
And my suggestions made it so the |
|
Ah, just realized that line numbers changed! Yes, will fix the expected files! |
erik-krogh
approved these changes
Feb 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the first part of #7803
Thanks to @max-schaefer for suggesting the dataflow alternative of enhancement I proposed
Summary of changes -
.getfunction ofMap