C++: Fix re-evaluation in cpp/return-stack-allocated-memory
#7830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffw0
approved these changes
Feb 3, 2022
Yeah, same :( |
|
OOI: could this problem be detected by a QL-for-QL query automatically? |
Maybe it could. As far as I understand the underlying problem, a query for this would need to model a lot of implementation details related to the order in which the QL compiler traverses files on disk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were, once again, hit by the IR re-evaluation problem because we didn't import
semmle.code.cpp.valuenumbering.GlobalValueNumberingbefore we imported the IR.