Misc: Streamline consistency-queries/qlpack.yml
#7842
Conversation
I'm not sure whether this means the consistency queries were run using the 0.0.1 release of the `codeql/ruby-all` qlpack, but using `"*"` at least ensures that it is always using the version from the CodeQL repo.
But no queries yet
| @@ -0,0 +1,5 @@ | |||
| name: codeql/python-consistency-queries | |||
| groups: [python, consistency-queries] | |||
There was a problem hiding this comment.
Should we add this to the other packs as well?
There was a problem hiding this comment.
Should we also add the test group? If I'm not mistaken QL packs in the test group are not published. @aeisenberg is that right?
There was a problem hiding this comment.
Good point 👍 Truth be told, I made the commits for streamlining the other languages and the one for adding the Python consistency queries on two separate days (originally in 2 separate branches), so I had forgotten about this detail.
There was a problem hiding this comment.
Yes. Since they are now part of the workspace, they will be picked up when publishing.
Note that if you remove the groups property, the they will be ignored. So, either add the test group here and to all consistency query packs. Or remove this group.
I'd prefer adding the test group here and else where since we may want to specify this in the future
as discussed in PR review
Wanted to add this for Python, so that was the day I learned about
.codeqlmanifest.json😮I looked at the
qlpack.ymlfor the other languages, and since they were all slightly different, I decided to streamline them. I also made them all use the preferreddependenciesinstead oflibraryPathDependencies.