Workflows: Augment workflow to ensure failure with invalid change notes #7946
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| name: Validate change notes | ||
|
|
||
| on: | ||
| push: | ||
| paths: | ||
| - "*/ql/*/change-notes/**/*" | ||
| - ".github/workflows/validate-change-notes.yml" | ||
| branches: | ||
| - main | ||
| - "rc/*" | ||
| pull_request: | ||
| paths: | ||
| - "*/ql/*/change-notes/**/*" | ||
| - ".github/workflows/validate-change-notes.yml" | ||
|
|
||
| jobs: | ||
| check-change-note: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v2 | ||
|
|
||
| - name: Setup CodeQL | ||
| uses: ./.github/actions/fetch-codeql | ||
|
|
||
| - name: Fail if there are any errors with existing change notes | ||
|
|
||
| run: | | ||
| codeql pack release --groups cpp,csharp,java,javascript,python,ruby,-examples,-test,-experimental | ||
|
There was a problem hiding this comment. Does this actually fail the step if There was a problem hiding this comment. Here is a workflow run that I intentionally failed. https://github.com/github/codeql/runs/5148220083?check_suite_focus=true It fails the job as well. |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should change
*/ql/src/**/*.qllto*/ql/**/*.qll(and same for.ql). Otherwise we're not running on changes that only affect the library packs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was committed accidentally. I think we should exclude tests and example packs from here. So, I will add a line like this:
*/ql/lib/**/*.qll. Same for*.ql. It's not really related to this change, but I'll add it anyway.