JS: fix most ql-for-ql warnings #7984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annarailton
approved these changes
Feb 11, 2022
kaeluka
approved these changes
Feb 15, 2022
| @@ -635,39 +635,18 @@ module TaintTracking { | |||
| pred.asExpr() = succ.getAstNode().(MethodCallExpr).getReceiver() and | |||
| ( | |||
| // sorted, interesting, properties of String.prototype | |||
| name = "anchor" or | |||
There was a problem hiding this comment.
for really large sets, readability suffers — like in this case. I like the consistency, though. But maybe the real issue here is the auto-formatter that won't allow having one line per item for large sets?
There was a problem hiding this comment.
+💯
One workaround we commonly is to put an empty line comment at the end of each item
There was a problem hiding this comment.
haha, thanks, I'll remember that trick :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 40 QL-for-QL warnings.
Mostly benign qldoc changes.
But there was a real bug in UnsafeCodeConstructionCustomizations.qll 😱
(The evaluation is on that query).
Evaluation looks fine.
(There are some new results in some minified files that are hard to triage).