Skip to content

C#: Downgrade hardcoded credentials queries to medium precision #8035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 15, 2022
Merged

C#: Downgrade hardcoded credentials queries to medium precision #8035

merged 3 commits into from
Feb 15, 2022

Conversation

tamasvajk
Copy link
Contributor

No description provided.

@tamasvajk tamasvajk requested a review from a team as a code owner February 15, 2022 08:34
@tamasvajk tamasvajk requested a review from yo-h February 15, 2022 08:35
@github-actions github-actions bot added the C# label Feb 15, 2022
michaelnebel
michaelnebel approved these changes Feb 15, 2022
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Has there been identified false positives?

@tamasvajk
Copy link
Contributor Author

LGTM! Has there been identified false positives?

I don't know what prompted these changes, but we're downgrading these checks for all languages (see the linked issue).

@yo-h yo-h merged commit cfcb06c into github:main Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelnebel michaelnebel michaelnebel approved these changes

@yo-h yo-h Awaiting requested review from yo-h

Assignees
No one assigned
Labels
C# documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tamasvajk @michaelnebel @yo-h