Skip to content

C++: Remove some unused legacy relations from the DB scheme - Take 2 #8036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 15, 2022

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Feb 15, 2022

Remove the following legacy relations:

  • snapshotDate
  • duplicateCode
  • similarCode
  • tokens

This is similar to the reverted #7982, except that externalData is kept, as it is used by the field team.

@jketema jketema force-pushed the remove-legacy-relations-2 branch from 24404d5 to 3b2584a Compare February 15, 2022 10:18
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@MathiasVP MathiasVP merged commit 38e4492 into github:main Feb 15, 2022
@jketema jketema deleted the remove-legacy-relations-2 branch February 15, 2022 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants