C#: Refactor Structural Comparison for Control Flow Elements. #8038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
added
the
no-change-note-required
tamasvajk
reviewed
Feb 17, 2022
csharp/ql/lib/semmle/code/csharp/commons/StructuralComparison.qll
Outdated
Show resolved
Hide resolved
csharp/ql/lib/semmle/code/csharp/commons/StructuralComparison.qll
Outdated
Show resolved
Hide resolved
csharp/ql/test/library-tests/structuralcomparison/structuralComparison.ql
Outdated
Show resolved
Hide resolved
Thank you for looking into this! |
michaelnebel
force-pushed
the
csharp/gvn-cfecomparison
branch
2 times, most recently
from
395d10f to
ec91e92
Compare
…een control flow elements and global value numbers.
…ntrol flow predicates, where we want to look for structural equality.
michaelnebel
force-pushed
the
csharp/gvn-cfecomparison
branch
from
ec91e92 to
23fbfbc
Compare
|
@hvitved: The DCA run now completed and it looks like there are no overall performance regressions. Some queries themselves might be a bit slower now, but maybe that could be linked to building the cache? There was identified a single "join order badness", but that is not side effect of this change. |
C#: Code review suggestions
hvitved
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we re-factor the existing implementation of the structural comparison for controls flow elements.
The new approach is based on a global value number approach.
The idea is strongly linked to the global value numbering used in the type unification.
Please note that the implementation is still hidden under the existing interface, but we plan to make a follow up PR where this is removed.