Skip to content

Ruby: Implement FileSystemWriteAccess concept #8138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 21, 2022
Merged

Ruby: Implement FileSystemWriteAccess concept #8138

merged 4 commits into from
Feb 21, 2022

Conversation

alexrford
Copy link
Contributor

e.g. File.write, IO.print, etc.

This necessitated some restructuring in Files.qll to clear things up a bit. IO/File read/write calls in general are mostly modelled in the abstract IOOrFileMethodCall and its implementations IOOrFileReadMethodCall and IOOrFileWriteMethodCall. The IO::FileReader and similar classes are then restrictions of those classes.

@alexrford alexrford added the Ruby label Feb 20, 2022
@alexrford alexrford requested a review from a team as a code owner February 20, 2022 20:07
hmac
hmac approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@hmac hmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a nice improvement!

@alexrford alexrford merged commit 9196b64 into main Feb 21, 2022
@alexrford alexrford deleted the ruby/file-write branch February 21, 2022 10:13
@alexrford alexrford mentioned this pull request Mar 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@hmac hmac hmac approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
documentation Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexrford @hmac