Skip to content

Add new xss queries to result counting query #8232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2022
Merged

Add new xss queries to result counting query #8232

merged 1 commit into from
Feb 24, 2022

Conversation

TomBolton
Copy link
Contributor

Add the new Xss queries to the CountAlertsAndEndpoints.ql query.

@TomBolton TomBolton added the JS label Feb 24, 2022
@TomBolton TomBolton requested review from henrymercer and a team February 24, 2022 14:05
henrymercer
henrymercer approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but keep in mind the performance implications of this change — as per the deprecation comment this query does not scale well with the number of security queries we extract alerts for.

@TomBolton
Copy link
Contributor Author

Thank you @henrymercer and yes, these two "cheap" Xss queries will be the final modification to the CountAlertsAndEndpoints.ql query before it gets replaced.

@TomBolton TomBolton merged commit 8dfc0d2 into main Feb 24, 2022
@TomBolton TomBolton deleted the tombolton/use-updated-counting-query branch February 24, 2022 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TomBolton @henrymercer