Skip to content

C++: Handle initialization of structured bindings via bitwise copy in extractor #8320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2022

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Mar 3, 2022

No description provided.

@github-actions github-actions bot added the C++ label Mar 3, 2022
@jketema jketema force-pushed the structured-binding-array branch 2 times, most recently from 304f7ba to ba66837 Compare March 4, 2022 10:59
@jketema jketema changed the title C++: Handle initialization via bitwise copy C++: Handle initialization of structured bindings via bitwise copy in extractor Mar 4, 2022
@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Mar 4, 2022
@jketema jketema marked this pull request as ready for review March 4, 2022 11:04
@jketema jketema requested a review from a team as a code owner March 4, 2022 11:04
@jketema jketema force-pushed the structured-binding-array branch 2 times, most recently from 5feada1 to 77561a8 Compare March 11, 2022 16:24
jketema added 2 commits March 15, 2022 23:22
…wise copy

These tests are in addition to exisiting tests involving default copy
constructors, which suffer from the same problem, i.e., the extractor not
handling bitwise copies.
@jketema jketema force-pushed the structured-binding-array branch from 77561a8 to d51cbe2 Compare March 15, 2022 22:22
Copy link

@dbartol dbartol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbartol dbartol merged commit e669ffa into github:main Mar 16, 2022
@jketema jketema deleted the structured-binding-array branch March 16, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants