Skip to content

Ruby: Fix regex parsing of /[|]/ #8364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 8, 2022
Merged

Ruby: Fix regex parsing of /[|]/ #8364

merged 3 commits into from
Mar 8, 2022

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Mar 8, 2022

The | in /[|]/ was previously parsed as both a RegExpConstant and a RegExpAlt; now it is only the former.

@github-actions github-actions bot added the Ruby label Mar 8, 2022
@hvitved hvitved marked this pull request as ready for review March 8, 2022 09:28
@hvitved hvitved requested a review from a team as a code owner March 8, 2022 09:28
@nickrolfe
Copy link
Contributor

cc @yoff @joefarebrother - worth checking if Python and Java need the same fix

@hvitved hvitved added the no-change-note-required This PR does not need a change note label Mar 8, 2022
@hvitved hvitved merged commit 8612116 into github:main Mar 8, 2022
@hvitved hvitved deleted the ruby/fix-regex-parse branch March 8, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aibaars aibaars aibaars approved these changes

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hvitved @nickrolfe @aibaars