JS: Add taint step for handlebars model #8430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-mc
changed the title
erik-krogh
reviewed
Mar 28, 2022
erik-krogh
reviewed
Mar 29, 2022
|
The autoformatter is failing on |
added 2 commits
March 31, 2022 12:32
erik-krogh
reviewed
Apr 1, 2022
There was a problem hiding this comment.
I did an evaluation.
(nightly-old + a bunch of random projects that use handlebars.compile(..).
I'm a bit worried about false flow in the case where we don't know the template string, but otherwise LGTM.
…o flow to helpers
erik-krogh
reviewed
Apr 13, 2022
javascript/ql/test/query-tests/Security/CWE-022/TaintedPath/handlebars.js
Show resolved
Hide resolved
|
@erik-krogh I think I've addressed all concerns. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a taint step that has been missing in the handlebars templating library. Passing data to a template may flow to custom 'helpers'. See the attached test and predicate documentation for details :)
Related CVE:
CVE-2022-24718
DCA
Experiment looking good.