Skip to content

C#: Model generator improvements and more tests #8451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Mar 23, 2022
Merged

C#: Model generator improvements and more tests #8451

merged 11 commits into from
Mar 23, 2022

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Mar 15, 2022 •
edited
Loading

In this PR we

  • Improve the model generation for callables that uses collection like types for parameters (or just types that has collection like types as base class)
  • Improve the model generation for callables that uses IEnumerable types as parameter types
  • Introduce more test cases.

@github-actions github-actions bot added the C# label Mar 15, 2022
@michaelnebel michaelnebel marked this pull request as ready for review March 16, 2022 12:47
@michaelnebel michaelnebel requested a review from a team as a code owner March 16, 2022 12:47
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Mar 16, 2022
hvitved
hvitved reviewed Mar 21, 2022
View reviewed changes
@michaelnebel michaelnebel requested a review from hvitved March 21, 2022 13:46
hvitved
hvitved requested changes Mar 22, 2022
View reviewed changes
@michaelnebel michaelnebel requested a review from hvitved March 23, 2022 11:05
@michaelnebel michaelnebel merged commit 6804e20 into github:main Mar 23, 2022
@michaelnebel michaelnebel deleted the csharp/modelgenerator-improvements branch March 23, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamasvajk tamasvajk tamasvajk left review comments

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaelnebel @hvitved @tamasvajk