Skip to content

JS: add missing @security-severity to JS queries #8459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 16, 2022
Merged

JS: add missing @security-severity to JS queries #8459

merged 2 commits into from
Mar 16, 2022

Conversation

erik-krogh
Copy link
Contributor

And stop the QL-for-QL query from flagging queries in a test folder.

@erik-krogh erik-krogh requested review from a team as code owners March 16, 2022 09:41
@erik-krogh erik-krogh added the no-change-note-required This PR does not need a change note label Mar 16, 2022
atorralba
atorralba approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@atorralba atorralba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 although I'm not a required reviewer :)

MathiasVP
MathiasVP approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QL 👍

@erik-krogh erik-krogh merged commit f53df25 into github:main Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esbena esbena esbena approved these changes

@MathiasVP MathiasVP MathiasVP approved these changes

+1 more reviewer

@atorralba atorralba atorralba approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
JS no-change-note-required This PR does not need a change note QL-for-QL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erik-krogh @esbena @MathiasVP @atorralba