Skip to content

Conversation

joshhale
Copy link

The bad examples for this code would prepend a - to the latlonCoords on the command-line, but the good example would not. I'm guessing this isn't an intentional divergence, and I found it a bit confusing.

@aschackmull
@felicity-semmle

@joshhale joshhale requested a review from a team as a code owner January 30, 2019 15:02
@ghost
Copy link

ghost commented Jan 30, 2019

CLA assistant check
All committers have signed the CLA.

@aschackmull
Copy link
Contributor

Josh, you need to sign the CLA.

@joshhale
Copy link
Author

@aschackmull Doesn't the comment above confirm that I have?

@aschackmull
Copy link
Contributor

Indeed. The CLA bot apparently edits its comment, which means that no notification is sent.

@aschackmull
Copy link
Contributor

I've retriggered CI.

@joshhale
Copy link
Author

The CLA bot apparently edits its comment, which means that no notification is sent.

Ah, confusing!

@aschackmull aschackmull merged commit 67b3279 into github:master Feb 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants