JS: update toString() on API-graph labels.
#8578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s on the API-graphs
tausbn
previously approved these changes
Mar 28, 2022
asgerf
previously approved these changes
Mar 29, 2022
asgerf
previously approved these changes
Apr 22, 2022
|
Did a merge to resolve a merge-conflict. In the merge I also updated the |
tausbn
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They now correspond to the predicate calls on the API-graph.
(Similarly to how Python/Ruby does it).
I like that approach better, and it makes our implementations more consistent across the languages.
The tests were updated to use the new toString(), and I updated the tests to be more similar to the tests in Python (that themselves were made to look similar to inline expectation tests).
Drive-by fix of the QLDoc for the same testing library in Python.
No evaluation planned.