-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ExponentialBackTracking: Speedup concretise
#8589
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cf7632c
to
596b8f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've achieved the same thing as I did in #8522, but much more concisely 👏
Could SuperlinearBackTracking.qll
get the same treatment?
javascript/ql/lib/semmle/javascript/security/performance/ExponentialBackTracking.qll
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 (Assuming the new evaluations work out)
There was some slowdown on |
I think you need a merge with |
3ada2c8
to
46d69cf
Compare
Rebased onto latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 (assuming a new evaluation works out).
There is still a bit of a slowdown on |
I read your comments about that, and I agree. It sounds like there are some unnecessary sorting when
Your solution is faster and more elegant than the solution I was planning, it massively improves the worst-case performance, and if the evaluator is fixed then the performance should be better in all cases. |
No description provided.