Skip to content

C#: Operator flow #8609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 1, 2022
Merged

C#: Operator flow #8609

merged 5 commits into from
Apr 1, 2022

Conversation

michaelnebel
Copy link
Contributor

In this PR, we make

  • Support for flow models for operators. This requires that we use the operator function name as the qualified name.
  • Exclude conversion operators from model generation (there is always flow through conversion operators in library code - see TaintTrackingPrivate.ql).
  • Exclude methods, where a namespace is not identified.

@github-actions github-actions bot added the C# label Mar 30, 2022
@michaelnebel michaelnebel marked this pull request as ready for review March 31, 2022 07:44
@michaelnebel michaelnebel requested a review from a team as a code owner March 31, 2022 07:44
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Mar 31, 2022
hvitved
hvitved approved these changes Mar 31, 2022
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should do a DCA run, since this touches the core hasQualifiedName predicate.

@michaelnebel
Copy link
Contributor Author

LGTM, but we should do a DCA run, since this touches the core hasQualifiedName predicate.

Makes sense. I will trigger one now.

@michaelnebel
Copy link
Contributor Author

There doesn't appear to be any query performance degradation during the DCA run (Powershell project is still failing to build, but this is a known issue). Merging now.

@michaelnebel michaelnebel merged commit c139850 into github:main Apr 1, 2022
@michaelnebel michaelnebel deleted the csharp/operatorsummaries branch April 1, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelnebel @hvitved