C#: Introduce generated flag as a part of the kind column for flow summaries #8628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/generatedkind
branch
2 times, most recently
from
1893bec to
a35b8c7
Compare
michaelnebel
force-pushed
the
csharp/generatedkind
branch
from
a35b8c7 to
387651d
Compare
… particular dataflow callable.
… that will not be discarded at run-time.
…o existing handwritten models.
michaelnebel
force-pushed
the
csharp/generatedkind
branch
2 times, most recently
from
17a0d1b to
15061e5
Compare
michaelnebel
force-pushed
the
csharp/generatedkind
branch
from
ce65a48 to
2562910
Compare
michaelnebel
added
the
no-change-note-required
|
Thoughts on making this its own column? |
We discussed it, but decided to go with this solutions as it is backwards compatible. |
|
I don't think backwards-compatibility is relevant yet. I think I'm leaning slightly towards making it its own column. @hvitved ? |
I don't really care; I am OK with adding another column for this. |
|
So should we add an extra column after the kind? |
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 9, 2022
…mmaries Equivalent of github#8628
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 9, 2022
…mmaries Equivalent of github#8628
owen-mc
added a commit
to owen-mc/codeql
that referenced
this pull request
Nov 17, 2022
…mmaries Equivalent of github#8628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we change the semantics slightly for the "kind" column in flow models.
valueortaint) can now be prefixed withgenerated:.generated, it is only used in case no summary exist that is not generated.