Swift: package test SDK #8784
Merged
Swift: package test SDK #8784
+31
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criemen
reviewed
Apr 20, 2022
| pkg_files( | ||
| name = "swift-test-sdk-arch", | ||
| srcs = [":swift-test-sdk"], | ||
| prefix = "qltest/" + codeql_platform, |
There was a problem hiding this comment.
is this a copy-paste error? (namely, the qltest part)
There was a problem hiding this comment.
That's on purpose. This idea is inherited from C++ support, though I cannot see any other usage of qltest in other language packs.
@criemen do you have a better place in mind? I'm happy to change/move this part if needed.
UPD:
usage of
qltest
as in "usage in the directory structure"
There was a problem hiding this comment.
I misunderstood what the PR is doing. I cleared that up now, this looks good to me 👍
criemen
approved these changes
Apr 20, 2022
| pkg_files( | ||
| name = "swift-test-sdk-arch", | ||
| srcs = [":swift-test-sdk"], | ||
| prefix = "qltest/" + codeql_platform, |
There was a problem hiding this comment.
I misunderstood what the PR is doing. I cleared that up now, this looks good to me 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test SDK used for basic testing of the Swift extractor.